fix: refactor: clean up apollo_federation::compile_service

src/core/blueprint/index.rs

@@ -180,13 +180,15 @@
         Self { map, schema: blueprint.schema.to_owned() }
     }
 }
 
 #[cfg(test)]
 mod test {
     use super::Index;
     use crate::core::blueprint::Blueprint;
     use crate::core::config::ConfigModule;
     use crate::include_config;
+    use insta::assert_snapshot;
+    use crate::federation::compile_service;
 
     fn setup() -> Index {
         let config = include_config!("./fixture/all-constructs.graphql").unwrap();
@@ -261,4 +263,18 @@
         assert!(index.is_type_implements("Post", "Post"));
         assert!(!index.is_type_implements("Node", "User"));
     }
+
+    #[test]
+    fn test_compile_service_snapshot() {
+        let config = include_config!("./fixture/all-constructs.graphql").unwrap();
+        let cfg_module = ConfigModule::from(config);
+
+        let result = compile_service(&cfg_module);
+
+        if let Valid::Success(IR::Service(output)) = result {
+            assert_snapshot!(output);
+        } else {
+            panic!("Expected Valid::Success");
+        }
+    }
 }

src/core/blueprint/operators/apollo_federation.rs → src/core/blueprint/operators/federation.rs

@@ -77,29 +77,27 @@
         },
     )
     .map_to(IR::Entity(resolver_by_type))
 }
 
 pub fn compile_service(config: &ConfigModule) -> Valid<IR, String> {
-    let mut sdl =
-        crate::core::document::print(filter_conflicting_directives(config.config().into()));
-
-    writeln!(sdl).ok();
-    // Add tailcall specific definitions to the sdl output
-    writeln!(
-        sdl,
-        "{}",
-        crate::core::document::print(filter_conflicting_directives(Config::graphql_schema()))
-    )
-    .ok();
-    writeln!(sdl).ok();
-    // Mark subgraph as Apollo federation v2 compatible according to [docs](https://www.apollographql.com/docs/apollo-server/using-federation/apollo-subgraph-setup/#2-opt-in-to-federation-2)
-    // (borrowed from async_graphql)
-    writeln!(sdl, "extend schema @link(").ok();
-    writeln!(sdl, "\turl: \"https://specs.apollo.dev/federation/v2.3\",").ok();
-    writeln!(sdl, "\timport: [\"@key\", \"@tag\", \"@shareable\", \"@inaccessible\", \"@override\", \"@external\", \"@provides\", \"@requires\", \"@composeDirective\", \"@interfaceObject\"]").ok();
-    writeln!(sdl, ")").ok();
-
-    Valid::succeed(IR::Service(sdl))
+    let mut service_doc = crate::core::document::print(filter_conflicting_directives(
+        config.config().into(),
+    ));
+
+    let additional_schema = crate::core::document::print(filter_conflicting_directives(
+        Config::graphql_schema(),
+    ));
+
+    let federation_v2_extension = r#"
+        extend schema @link(
+            url: "https://specs.apollo.dev/federation/v2.3",
+            import: ["@key", "@tag", "@shareable", "@inaccessible", "@override", "@external", "@provides", "@requires", "@composeDirective", "@interfaceObject"]
+        )
+    "#;
+
+    writeln!(service_doc, "{}\n{}", additional_schema, federation_v2_extension).ok();
+
+    Valid::succeed(IR::Service(service_doc))
 }
 
 fn filter_conflicting_directives(sd: ServiceDocument) -> ServiceDocument {

src/core/blueprint/operators/mod.rs

@@ -1,19 +1,19 @@
-mod apollo_federation;
+mod federation;
 mod call;
 mod enum_alias;
 mod expr;
 mod graphql;
 mod grpc;
 mod http;
 mod js;
 mod modify;
 mod protected;
 
-pub use apollo_federation::*;
+pub use federation::*;
 pub use call::*;
 pub use enum_alias::*;
 pub use expr::*;
 pub use graphql::*;
 pub use grpc::*;
 pub use http::*;
 pub use js::*;