refactor(2904): clean up apollo federation

src/core/blueprint/index.rs

@@ -180,14 +180,19 @@
         Self { map, schema: blueprint.schema.to_owned() }
     }
 }
 
 #[cfg(test)]
 mod test {
     use super::Index;
     use crate::core::blueprint::Blueprint;
     use crate::core::config::ConfigModule;
+    use crate::core::valid::Valid;
+    use crate::core::ir::model::IR;
+    use crate::core::blueprint::operators::federation::compile_service;
+    use insta::assert_snapshot;
     use crate::include_config;
 
+
     fn setup() -> Index {
         let config = include_config!("./fixture/all-constructs.graphql").unwrap();
         let cfg_module = ConfigModule::from(config);
@@ -261,4 +266,18 @@
         assert!(index.is_type_implements("Post", "Post"));
         assert!(!index.is_type_implements("Node", "User"));
     }
+
+    #[test]
+    fn test_compile_service_snapshot() {
+        let config = include_config!("./fixture/all-constructs.graphql").unwrap();
+        let cfg_module = ConfigModule::from(config);
+
+        let result = compile_service(&cfg_module);
+
+        if let Ok(IR::Service(output)) = result {
+            assert_snapshot!(output);
+        } else {
+            panic!("Expected Valid::Success");
+        }
+    }
 }

src/core/blueprint/operators/apollo_federation.rs → src/core/blueprint/operators/federation.rs

@@ -79,27 +79,40 @@
     .map_to(IR::Entity(resolver_by_type))
 }
 
-pub fn compile_service(config: &ConfigModule) -> Valid<IR, String> {
-    let mut sdl =
-        crate::core::document::print(filter_conflicting_directives(config.config().into()));
-
-    writeln!(sdl).ok();
-    // Add tailcall specific definitions to the sdl output
-    writeln!(
-        sdl,
-        "{}",
-        crate::core::document::print(filter_conflicting_directives(Config::graphql_schema()))
-    )
-    .ok();
-    writeln!(sdl).ok();
-    // Mark subgraph as Apollo federation v2 compatible according to [docs](https://www.apollographql.com/docs/apollo-server/using-federation/apollo-subgraph-setup/#2-opt-in-to-federation-2)
-    // (borrowed from async_graphql)
-    writeln!(sdl, "extend schema @link(").ok();
-    writeln!(sdl, "\turl: \"https://specs.apollo.dev/federation/v2.3\",").ok();
-    writeln!(sdl, "\timport: [\"@key\", \"@tag\", \"@shareable\", \"@inaccessible\", \"@override\", \"@external\", \"@provides\", \"@requires\", \"@composeDirective\", \"@interfaceObject\"]").ok();
-    writeln!(sdl, ")").ok();
-
-    Valid::succeed(IR::Service(sdl))
+pub fn compile_service(config: &ConfigModule) -> Result<Valid<IR>, String> {
+    let mut service_doc = ServiceDocument::from(config.config().into());
+
+    let federation_directive = DirectiveDefinition {
+        name: "link".to_string(),
+        arguments: vec![
+            Argument {
+                name: "url".to_string(),
+                value: Value::String("https://specs.apollo.dev/federation/v2.3".to_string()),
+            },
+            Argument {
+                name: "import".to_string(),
+                value: Value::List(vec![
+                    Value::String("@key".to_string()),
+                    Value::String("@tag".to_string()),
+                    Value::String("@shareable".to_string()),
+                    Value::String("@inaccessible".to_string()),
+                    Value::String("@override".to_string()),
+                    Value::String("@external".to_string()),
+                    Value::String("@provides".to_string()),
+                    Value::String("@requires".to_string()),
+                    Value::String("@composeDirective".to_string()),
+                    Value::String("@interfaceObject".to_string()),
+                ]),
+            },
+        ],
+    };
+
+    service_doc.add_directive(federation_directive);
+
+    let mut complete_sdl = String::new();
+    writeln!(complete_sdl, "{}", crate::core::document::print(service_doc))?;
+
+    Ok(Valid::succeed(IR::Service(complete_sdl)))
 }
 
 fn filter_conflicting_directives(sd: ServiceDocument) -> ServiceDocument {

src/core/blueprint/operators/mod.rs

@@ -1,19 +1,19 @@
-mod apollo_federation;
+pub mod federation;
 mod call;
 mod enum_alias;
 mod expr;
 mod graphql;
 mod grpc;
 mod http;
 mod js;
 mod modify;
 mod protected;
 
-pub use apollo_federation::*;
+pub use federation::*;
 pub use call::*;
 pub use enum_alias::*;
 pub use expr::*;
 pub use graphql::*;
 pub use grpc::*;
 pub use http::*;
 pub use js::*;