Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support mustache on link directives #3176

Merged
merged 18 commits into from
Nov 29, 2024
Merged

feat: Support mustache on link directives #3176

merged 18 commits into from
Nov 29, 2024

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #3174

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Nov 28, 2024
@ssddOnTop ssddOnTop marked this pull request as draft November 28, 2024 20:50
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.63%. Comparing base (02c7821) to head (70528d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/mustache/eval.rs 85.71% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3176   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files         277      277           
  Lines       27674    27709   +35     
=======================================
+ Hits        23975    24007   +32     
- Misses       3699     3702    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssddOnTop ssddOnTop marked this pull request as ready for review November 29, 2024 01:47
@tusharmath tusharmath enabled auto-merge (squash) November 29, 2024 19:15
@tusharmath tusharmath merged commit 9039963 into main Nov 29, 2024
31 checks passed
@tusharmath tusharmath deleted the feat/mustache-for-link1 branch November 29, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Support mustache on link directives
2 participants
@ssddOnTop @tusharmath