Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use links only from the root config #3190

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Dec 3, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Phase 1 of #3164

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (61d79d6) to head (f141535).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/config_module/merge.rs 95.23% 1 Missing ⚠️
src/core/config/reader.rs 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
- Coverage   86.66%   86.65%   -0.02%     
==========================================
  Files         277      277              
  Lines       27761    27769       +8     
==========================================
+ Hits        24059    24063       +4     
- Misses       3702     3706       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant