feat: add ignore option to tailwind plugin #17482
Conversation
| return matcher(id); | ||
| } | ||
|
|
||
| return matcher.includes(matcher) |
There was a problem hiding this comment.
not sure what to do in this case if it's a string, or if you want to support this use-case at all, maybe it would make sense to offload it to the user with the matcher function above
|
Not sure if tests are needed? ready to write any if yes! |
|
Hey! Thanks for the PR but I think it would be even better if we can allow these plugins without requiring a configuration option. Do you have a repro for one specific example? The discussion you linked two has two issues one from |
|
That would probably be the ideal outcome, although not sure if it's realistic as that's what vanilla extract tried to do as well and ran into interop issues with a few plugins and gave up on it, not saying it will happen to tailwind but it's a possibility, I'll create a repro for vanilla, the other one I'm not really familiar with and can't be of much help there, but I'm guessing you run into it as soon as you use polaris to generate css. For vanilla I know their vite plugin listens to |
|
@philipp-spiess sorry for the wait, here's a vanilla repro: |
Added an optional ignore flag for the tailwind plugin to ignore certain files and allow for easier configuration with other plugins
Needed for better interop with other plugins, eg:
#16712