Skip to content

Add discrete properties to the default list of transition properties #17812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philipp-spiess
Copy link
Member

This PR changes the transition utility to include five new properties:

  • display
  • visibility
  • content-visibility
  • overlay
  • pointer-eventes

On its own, this change does nothing since these properties will apply their change immediately. However, in combination with transition-discrete this will ensure that you can now transition these types without requiering transition-all or arbitrary transition properties.

Test plan

  • Ensured this works in the Vite playground with native <dialog> components
Screen.Recording.2025-04-28.at.18.01.21.mov

Notice how:

  • the backdrop stays open until the transition is over (that's because of overlay in the property list)
  • the dialog is displayed until the transition is over

@philipp-spiess philipp-spiess requested a review from a team as a code owner April 28, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant