Skip to content

Update test to retry assertion on empty file and don't include forward-slash in the assertion #17821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 29, 2025

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Apr 29, 2025

To fix the CI issues we have, it turns out there are two issues:

  1. The file-read was not retried, making it possible for all platforms (but mostly Windows because it's the slowest) to sometimes not have the file created yet before making the assertion.
  2. A forward-slash in the assertion message path would always be a backslash when run on Windows, thus the Windows test would never pass.

[ci-all]

Test plan

  • [ci-all] and have the test pass two times.

@philipp-spiess philipp-spiess marked this pull request as ready for review April 29, 2025 15:54
@philipp-spiess philipp-spiess requested a review from a team as a code owner April 29, 2025 15:54
@philipp-spiess philipp-spiess changed the title Update test to retry assertion on empty file Update test to retry assertion on empty file and don't include forward-slash in the assertion Apr 29, 2025
@philipp-spiess philipp-spiess merged commit d3846a4 into main Apr 29, 2025
21 checks passed
@philipp-spiess philipp-spiess deleted the chore/ci-fix-2 branch April 29, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants