Fixed route bug in path detection

taiwen · Apr 10, 2013 · 133c652 · 133c652
1 parent 53cbe83
commit 133c652
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/lib/Pi/Log/Writer/Debugger.php b/lib/Pi/Log/Writer/Debugger.php
@@ -195,7 +195,7 @@ public function systemInfo()
             $system['Cache Storage'] = $class;
         }
         if (Pi::service()->hasService('module')) {
-            $system['Module'] = Pi::service('module')->current();
+            $system['Module'] = Pi::service('module')->current() ?: 'N/A';
         }
         if (Pi::service()->hasService('theme')) {
             $system['Theme'] = Pi::service('theme')->current();

diff --git a/lib/Pi/Mvc/Router/Http/Standard.php b/lib/Pi/Mvc/Router/Http/Standard.php
@@ -166,8 +166,10 @@ protected function canonizePath(Request $request, $pathOffset = null)
         $pathLength = strlen($path);
 
         if ($this->prefix) {
-            $prefixLength = strlen($this->prefix);
-            if ($this->prefix != substr($path, 0, $prefixLength)) {
+            $prefix = rtrim($this->prefix, $this->paramDelimiter) . $this->paramDelimiter;
+            $path = rtrim($path, $this->paramDelimiter) . $this->paramDelimiter;
+            $prefixLength = strlen($prefix);
+            if ($prefix != substr($path, 0, $prefixLength)) {
                 return null;
             }
             $path = substr($path, $prefixLength);

diff --git a/usr/theme/default/template/error-404.phtml b/usr/theme/default/template/error-404.phtml
@@ -45,7 +45,7 @@
                 && $this->controller_class
                 && $this->controller_class != $this->controller
             ) {
-                echo ' (resolves to'  . $this->escape($this->controller_class) . ')';
+                echo ' (resolves to '  . $this->escape($this->controller_class) . ')';
             }
             ?>
         </dd>