Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/2025 01 survey performance #380

Merged
merged 44 commits into from
Feb 8, 2025

Conversation

takapi327
Copy link
Owner

@takapi327 takapi327 commented Jan 28, 2025

Implementation Details

The change was made because the method of splitting using splitAt was faster than using the helper functions provided by scodec.

Before

Select

After

Select

Fixes

Issues #265

Pull Request Checklist

  • Wrote unit and integration tests
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code formatting by scalafmt (sbt scalafmtAll command execution)
  • Add copyright headers to new files

References

@takapi327 takapi327 added 💪 enhancement Functional enhancement 🔧 refactor Refactoring ldbc:connector Addition and modification of functionality to Connector projects labels Jan 28, 2025
@takapi327 takapi327 added this to the 0.3.0 milestone Jan 28, 2025
@takapi327 takapi327 self-assigned this Jan 28, 2025
@takapi327 takapi327 marked this pull request as draft January 30, 2025 10:35
@takapi327 takapi327 marked this pull request as ready for review February 8, 2025 12:45
@takapi327 takapi327 merged commit 306fb54 into master Feb 8, 2025
27 checks passed
@takapi327 takapi327 deleted the enhancement/2025-01-survey-performance branch February 8, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement Functional enhancement ldbc:connector Addition and modification of functionality to Connector projects 🔧 refactor Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant