modernize cln tests and CI #259
Conversation
| @@ -69,4 +73,4 @@ jobs: | |||
| - name: Run tests | |||
| run: | | |||
| cd watchtower-plugin/tests | |||
| DEVELOPER=1 SLOW_MACHINE=1 poetry run pytest test.py --log-cli-level=INFO -s | |||
| VALGRIND=0 SLOW_MACHINE=1 poetry run pytest test.py --log-cli-level=INFO -s | |||
There was a problem hiding this comment.
Is VALGRIND enabled by default?
There was a problem hiding this comment.
i think so, but not sure when and where it's used to be honest
daywalker90
force-pushed
the
modernize-cln-tests
branch
from
f76d3c9 to
481768a
Compare
|
Ah yes thanks github for changing the default branch name. |
There was a problem hiding this comment.
Looks like we are still facing several issues:
allow_broken_logdoesn't seem to be an option anymore: https://github.com/talaia-labs/rust-teos/actions/runs/9731968733/job/27975219502?pr=259#step:9:89geventdoesn't seem to be installed so theclnrestplugin is being killed on init: https://github.com/talaia-labs/rust-teos/actions/runs/9731968733/job/27975219502?pr=259#step:9:86- The
cln-grpcplugin is missing needs to be passed a port, so it's also being killed on init: https://github.com/talaia-labs/rust-teos/actions/runs/9731968733/job/27975219502?pr=259#step:9:134
daywalker90
force-pushed
the
modernize-cln-tests
branch
from
481768a to
dd65ad8
Compare
|
@sr-gi clnrest and cln-grpc are just plugins to serve the rpc via REST and GRPC. They are not relevant for this project and can safely be ignored. I removed the functions mentioning DEVELOPER. I'm not sure how they were still used, i could not find any code for them anymore. Indeed allow_broken_log was removed in favor of broken_log which requires explicitly stating the expected broken log. Please check that the log lines i used are actually expected! |
watchtower-plugin/tests/test.py
Outdated
| @@ -123,7 +120,7 @@ def test_auto_retry_watchtower(node_factory, bitcoind, teosd): | |||
| {}, | |||
| { | |||
| "plugin": WT_PLUGIN, | |||
| "allow_broken_log": True, | |||
| "broken_log": r'plugin-watchtower-client: Data was send to an idle retier. This should have never happened. Please report!.*', | |||
There was a problem hiding this comment.
This made me realize that there was a typo on this logline. Would you care changing it here and on the plugin side?
retier -> retrier
daywalker90
force-pushed
the
modernize-cln-tests
branch
from
dd65ad8 to
f6decde
Compare
done
done |
|
LGTM. Rust lint issues are unrelated. Any additional comment @mariocynicys? |
Replaces #255
I think in your PR tests ran slow because you were running them on an ancient pyln-testing version. Just to make sure i added VALGRIND=0 as that can cause huge slowdowns but i don't know when valgrind actually runs in these tests.
I also assume you don't want CI to run on anything else than commit to the master branch. While testing with a PR all CI ran both for the feature branch and the PR kinda weird.
Also
developer: Noneis not needed with a modernpyln-testingversion, as that is a default setting.