Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests, code coverage and some new functionality #43

Merged
merged 56 commits into from
Apr 9, 2017
Merged

Conversation

alanocallaghan
Copy link
Collaborator

This implements native plotly heatmaps (#20), font size params (#39), cellnote (#42), support for long data and altered mouseover labels (#37 and #36).

I will double check these edits before merging, this is merely an easy way to compare.

Basic tests and code coverage reporting are implemented here. I'm not 100% about how to add a coverage badge, though you could make an account on codecov.io to add it yourself

@codecov-io
Copy link

codecov-io commented Apr 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@db6f9d0). Click here to learn what that means.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage          ?   87.78%           
=========================================
  Files             ?        6           
  Lines             ?      794           
  Branches          ?        0           
=========================================
  Hits              ?      697           
  Misses            ?       97           
  Partials          ?        0
Impacted Files Coverage Δ
R/percentize.R 25.64% <100%> (ø)
R/heatmapr.R 87.87% <81.25%> (ø)
R/plots.R 85.49% <85.49%> (ø)
R/heatmaply.R 96.16% <93.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6f9d0...bf72432. Read the comment docs.

@talgalili
Copy link
Owner

I added a badge. Great set of tests - thanks!

@alanocallaghan
Copy link
Collaborator Author

Hopefully if we split out some of the functionality the tests can become a bit more granular, but it's a good start. I'm glad to have put them in, because they keep catching mistakes :)

@alanocallaghan alanocallaghan merged commit 1956d0a into master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants