IOS-8946 Remove eye feature #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tureck1y
commented
Jan 23, 2025
•
tureck1y
commented
- удален глазик
tureck1y
requested review from
m3g0byt3,
skibinalexander,
Andoran90 and
fedorov-d
tureck1y
commented
Jan 23, 2025
| if shouldBecomeFirstResponder { | ||
| setFocus(for: isSecured) | ||
| SecureField("", text: text, onCommit: onCommit) | ||
| .textContentType(.oneTimeCode) // to prevent passwords suggestion. Tested on ios 15-18 |
There was a problem hiding this comment.
интересно, что сработало только это, пробовал username, пустую строку
skibinalexander
previously approved these changes
Jan 24, 2025
Andoran90
reviewed
Jan 27, 2025
| SecureField("", text: text, onCommit: onCommit) | ||
| .textContentType(.oneTimeCode) // to prevent passwords suggestion. Tested on ios 15-18 | ||
| .focused($focusedField, equals: .secure) | ||
| .keyboardType(.asciiCapable) |
There was a problem hiding this comment.
не опасно ли это сейчас менять? а если кто-то задал код кириллицей или ещё чем-то другим, они же не смогут его ввести? Не чекал этот кейс?
There was a problem hiding this comment.
да, ты прав, я откачу это и правку c textContentType, потому что предлагается ввести OTP, если он есть, т.к. apple не усеет понимать от какого приложения код
There was a problem hiding this comment.
может стоит сделать задание .keyboardType извне и для задания нового пароля уже поставить .ascii?
There was a problem hiding this comment.
зачем, нам нет смысл ограничивать пароль как-либо кроме policy на количество знаков и тп
fedorov-d
approved these changes
Jan 27, 2025
Andoran90
approved these changes
Jan 28, 2025
m3g0byt3
approved these changes
Jan 28, 2025
m3g0byt3
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.