refactor.

tangs · Jul 8, 2024 · 5af289d · 5af289d
1 parent a826aa8
commit 5af289d
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 44 deletions.
diff --git a/src/724/solution.hpp b/src/724/solution.hpp
@@ -10,7 +10,8 @@ using namespace std;
 
 class Solution {
 public:
-    int pivotIndex(vector<int>&& nums) {
+    template<typename T>
+    int pivotIndex(T&& nums) {
         const auto len = nums.size();
         nums.push_back(0);
 

diff --git a/tests/3303/CMakeLists.txt b/tests/3303/CMakeLists.txt
@@ -1,37 +1,37 @@
-cmake_minimum_required(VERSION 3.10)
-project(dp_solution_pipeline)
-
-set(CMAKE_CXX_STANDARD 17)
-
-set(PROBLEM_NAME 3303)
-
-include(FetchContent)
-FetchContent_Declare(
-        googletest
-        URL https://github.com/google/googletest/archive/03597a01ee50ed33e9dfd640b249b4be3799d395.zip
-)
-set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
-FetchContent_MakeAvailable(googletest)
-
-set(SRC_ROOT_PATH ${ROOT_PATH}/src)
-set(SRC_PATH ${SRC_ROOT_PATH}/${PROBLEM_NAME})
-set(TESTS_PATH ${ROOT_PATH}/tests/${PROBLEM_NAME})
-
-include_directories(
-        ${SRC_ROOT_PATH}
-        ${SRC_PATH}
-        ${TESTS_PATH}
-)
-
-# test.
-enable_testing()
-
-add_executable(
-        test_${PROBLEM_NAME}
-        ${TESTS_PATH}/test.cc
-)
-target_link_libraries(test_${PROBLEM_NAME} GTest::gtest_main)
-
-
-include(GoogleTest)
-gtest_discover_tests(test_${PROBLEM_NAME})
+#cmake_minimum_required(VERSION 3.10)
+#project(dp_solution_pipeline)
+#
+#set(CMAKE_CXX_STANDARD 17)
+#
+#set(PROBLEM_NAME 3303)
+#
+#include(FetchContent)
+#FetchContent_Declare(
+#        googletest
+#        URL https://github.com/google/googletest/archive/03597a01ee50ed33e9dfd640b249b4be3799d395.zip
+#)
+#set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
+#FetchContent_MakeAvailable(googletest)
+#
+#set(SRC_ROOT_PATH ${ROOT_PATH}/src)
+#set(SRC_PATH ${SRC_ROOT_PATH}/${PROBLEM_NAME})
+#set(TESTS_PATH ${ROOT_PATH}/tests/${PROBLEM_NAME})
+#
+#include_directories(
+#        ${SRC_ROOT_PATH}
+#        ${SRC_PATH}
+#        ${TESTS_PATH}
+#)
+#
+## test.
+#enable_testing()
+#
+#add_executable(
+#        test_${PROBLEM_NAME}
+#        ${TESTS_PATH}/test.cc
+#)
+#target_link_libraries(test_${PROBLEM_NAME} GTest::gtest_main)
+#
+#
+#include(GoogleTest)
+#gtest_discover_tests(test_${PROBLEM_NAME})
diff --git a/tests/724/test.cc b/tests/724/test.cc
@@ -3,11 +3,14 @@
 #include "utils/utils.h"
 #include "solution.hpp"
 
-TEST(testing, BasicAssertions) {
+TEST(testing_pivotIndex, BasicAssertions) {
     Solution solution;
     EXPECT_EQ(solution.pivotIndex(std::vector{1, 7, 3, 6, 5, 6}), 3);
-    EXPECT_EQ(solution.pivotIndex({1, 2, 3}), -1);
-    EXPECT_EQ(solution.pivotIndex({2, 1, -1}), 0);
-    EXPECT_EQ(solution.pivotIndex({2, 1, -3}), -1);
-    EXPECT_EQ(solution.pivotIndex({-2, 2, -3}), 2);
-}
+    EXPECT_EQ(solution.pivotIndex(std::vector{1, 2, 3}), -1);
+    EXPECT_EQ(solution.pivotIndex(std::vector{2, 1, -1}), 0);
+    EXPECT_EQ(solution.pivotIndex(std::vector{2, 1, -3}), -1);
+    EXPECT_EQ(solution.pivotIndex(std::vector{-2, 2, -3}), 2);
+    EXPECT_EQ(solution.pivotIndex(std::vector{1, 2, 3, 4, 2, 10}), 4);
+    auto vec = std::vector{1, 2, 3, 4, 2, 10};
+    EXPECT_EQ(solution.pivotIndex(vec), 4);
+}