Merge pull request #2218 from taozhi8833998/refactor-listagg-func-sno…

…wflake refactor: support listagg function in snowflake
taozhi8833998 · Nov 14, 2024 · ef06368 · ef06368
2 parents 4052b28 + b7fb639
commit ef06368
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/pegjs/snowflake.pegjs b/pegjs/snowflake.pegjs
@@ -3704,7 +3704,7 @@ KW_SUM_MAX_MIN_AVG
   = KW_SUM / KW_MAX / KW_MIN / KW_AVG
 
 aggr_fun_count
-  = name:(KW_COUNT / KW_GROUP_CONCAT) __ LPAREN __ arg:count_arg __ RPAREN __ bc:over_partition? {
+  = name:(KW_COUNT / KW_GROUP_CONCAT / 'LISTAGG'i) __ LPAREN __ arg:count_arg __ RPAREN __ bc:over_partition? {
     // => { type: 'aggr_func'; name: 'COUNT' | 'GROUP_CONCAT'; args:count_arg; over: over_partition }
       return {
         type: 'aggr_func',
@@ -3740,7 +3740,7 @@ concat_separator
   = kw:COMMA __ s:literal_string {
     // => { symbol: ','; delimiter: literal_string; }
     return {
-      symbol: ke,
+      symbol: kw,
       delimiter: s
     }
   }

diff --git a/test/snowflake.spec.js b/test/snowflake.spec.js
@@ -448,6 +448,13 @@ describe('snowflake', () => {
         'SELECT "bi_json"."limit" AS "limit" FROM "modelc"'
       ]
     },
+    {
+      title: 'listagg function',
+      sql: [
+        'select listagg(distinct id, ", ") as ids from foo;',
+        'SELECT listagg(DISTINCT "id", ", ") AS "ids" FROM "foo"'
+      ]
+    },
   ]
   SQL_LIST.forEach(sqlInfo => {
     const { title, sql } = sqlInfo