Always renew sk-api token creation credentials #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of the new Kubernetes feature for setting restartPolicy for initContainers, so renew-sk-secret-script will run more reliably
Added an infinite loop to retry getting credentials, and error-checking. This avoids sk-api getting into an infinite loop of its own, from which it can't recover, when sk-secret is bad. The result is more robustness when sk-api starts before the vault or while the vault is sealed.
The export statements for KUBE_TOKEN and KUBE_NAMESPACE were deleted by mistake, this restores them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Deployer option to use an initContainer to obtain vault token creation credentials for sk-api, you would expect those credentials to be renewed whenever sk-api is restarted by Kubernetes, but that doesn't always happen due to the way Kubernetes works (this is a known design decision discussed elsewhere). This patch levers the new Kubernetes 1.28 option for init containers to have a restart policy. The init container will always restart, and the renewal script will loop until it gets credentials from the vault, ensuring that sk-api is always able to function if the vault is running and unsealed.