-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML Hub models api calls #364
Conversation
…iled info for each model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this file something semantically closer to the purpose of this function ( fetching inference server details for a given model) and/or what it returns? 1. inferenceAvailable
sounds like it should return a boolean value. 2. Knowing whether an inference server is available is secondary information that we can derive from the value of the result. I recommend something like src/tapis-api/models/inference-servers/details.ts
import { Models } from '@tapis/tapis-typescript'; | ||
import { apiGenerator, errorDecoder } from 'tapis-api/utils'; | ||
|
||
const downloadLinks = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the comment above, this should be called something like details
. The name of the function should be the same as the name of the file.
const QueryKeys = { | ||
list: 'ml-hub/models/list', | ||
details: 'ml-hub/models/details', | ||
downloadLinks: 'ml-hub/models/downloadLinks', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps inferenceServerDetails: 'ml-hub/models/inferenceServerDetails'
Overview:
Related Github Issues:
Summary of Changes:
Created API calls in
tapis-api
and hooks intapis-hooks
for the following functionalities:Testing Steps:
UI Photos:
Notes: