Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/t UI 357 cancel job button #422

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

carrythemountain
Copy link
Collaborator

Overview:

Related Github Issues:

Summary of Changes:

Testing Steps:

UI Photos:

Notes:

Copy link
Collaborator

@nathandf nathandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work sir. And fast, thanks.

I would just ask that you add some screenshots of the UI that capture your changes

@carrythemountain
Copy link
Collaborator Author

carrythemountain commented Aug 28, 2024

Screenshot 2024-08-28 at 2 33 29 PM Screenshot 2024-08-28 at 2 34 08 PM Screenshot 2024-08-28 at 2 34 50 PM

My pleasure good sir! Here are those screenshots!

@nathandf
Copy link
Collaborator

i see an error in the second screenshot. The Cancel button should be disabled for jobs with a status of CANCELED but it's not

@carrythemountain
Copy link
Collaborator Author

i see an error in the second screenshot. The Cancel button should be disabled for jobs with a status of CANCELED but it's not

My apologies, these are uploaded out of order. The first shows the latter of the changes, the second shows the former.

@nathandf
Copy link
Collaborator

By former, do you mean what it looked like before you made the changes?

@nathandf nathandf merged commit fd78d30 into dev Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants