allow either code or entrypoint on function tasks

tapis-project · Oct 18, 2023 · 39f2622 · 39f2622
1 parent 004f850
commit 39f2622
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/api/src/backend/views/http/requests.py b/src/api/src/backend/views/http/requests.py
@@ -635,9 +635,16 @@ class FunctionTask(BaseTask):
     runtime: EnumRuntimeEnvironment
     packages: List[str] = []
     installer: EnumInstaller
-    code: str
+    code: str = None
+    entrypoint: str = None
     command: str = None
 
+    @root_validator(pre=True)
+    def code_or_entrypoint(cls, values):
+        if values.get("code", None) == None and values.get("entrypoint", None) == None:
+            raise ValueError("Function tasks must define at least one of the following: [code, entrypoint] | Neither were defined")
+
+        return values
 # Pipelines
 
 Task = Annotated[
@@ -696,6 +703,7 @@ def backwards_compatibility_transforms(cls, values):
                 }
 
         return values
+
     class Config:
         extra = Extra.allow
 

diff --git a/src/engine/src/owe_python_sdk/schema.py b/src/engine/src/owe_python_sdk/schema.py
@@ -635,9 +635,16 @@ class FunctionTask(BaseTask):
     runtime: EnumRuntimeEnvironment
     packages: List[str] = []
     installer: EnumInstaller
-    code: str
+    code: str = None
+    entrypoint: str = None
     command: str = None
 
+    @root_validator(pre=True)
+    def code_or_entrypoint(cls, values):
+        if values.get("code", None) == None and values.get("entrypoint", None) == None:
+            raise ValueError("Function tasks must define at least one of the following: [code, entrypoint] | Neither were defined")
+
+        return values
 # Pipelines
 
 Task = Annotated[
@@ -696,6 +703,7 @@ def backwards_compatibility_transforms(cls, values):
                 }
 
         return values
+
     class Config:
         extra = Extra.allow