Skip to content

Commit

Permalink
tdg_dashboard: display only 99th quantile
Browse files Browse the repository at this point in the history
Display only 99th quantile for Prometheus TDG Kafka metrics:
- "TDG Kafka brokers statistics" panels:
  - "Producer queue latency" (tdg_kafka_broker_int_latency),
  - "Request queue latency" (tdg_kafka_broker_outbuf_latency),
  - "Broker latency" (tdg_kafka_broker_rtt),
  - "Broker throttle" (tdg_kafka_broker_throttle);
- "TDG Kafka topics statistics" panels:
  - "Batch size" (tdg_kafka_topic_batchsize),
  - "Batch message count" (tdg_kafka_topic_batchcnt).

Closes #156
  • Loading branch information
DifferentialOrange committed Jun 24, 2022
1 parent cb30dba commit 130ef88
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Fixed
- TDG dashboard file connectors processed panel name changed to "Total files processed"
- Set valid metrics name to TDG dashboard Kafka partitions panels
- Display only 99th quantile for Prometheus TDG Kafka metrics


## [1.2.0] - 2022-06-08
Expand Down
2 changes: 1 addition & 1 deletion dashboard/panels/tdg/kafka/brokers.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ local prometheus = grafana.prometheus;
) =
if datasource == '${DS_PROMETHEUS}' then
prometheus.target(
expr=std.format('%s{job=~"%s"}',
expr=std.format('%s{job=~"%s",quantile="0.99"}',
[metric_name, job]),
legendFormat='{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})',
)
Expand Down
2 changes: 1 addition & 1 deletion dashboard/panels/tdg/kafka/topics.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ local prometheus = grafana.prometheus;
) =
if datasource == '${DS_PROMETHEUS}' then
prometheus.target(
expr=std.format('%s{job=~"%s"}',
expr=std.format('%s{job=~"%s",quantile="0.99"}',
[metric_name, job]),
legendFormat='{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})',
)
Expand Down
12 changes: 6 additions & 6 deletions tests/Prometheus/dashboard_tdg_compiled.json
Original file line number Diff line number Diff line change
Expand Up @@ -11764,7 +11764,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_broker_int_latency{job=~\"$job\"}",
"expr": "tdg_kafka_broker_int_latency{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down Expand Up @@ -11854,7 +11854,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_broker_outbuf_latency{job=~\"$job\"}",
"expr": "tdg_kafka_broker_outbuf_latency{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down Expand Up @@ -11944,7 +11944,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_broker_rtt{job=~\"$job\"}",
"expr": "tdg_kafka_broker_rtt{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down Expand Up @@ -12034,7 +12034,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_broker_throttle{job=~\"$job\"}",
"expr": "tdg_kafka_broker_throttle{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{broker_name}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down Expand Up @@ -12324,7 +12324,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_topic_batchsize{job=~\"$job\"}",
"expr": "tdg_kafka_topic_batchsize{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down Expand Up @@ -12414,7 +12414,7 @@
"steppedLine": false,
"targets": [
{
"expr": "tdg_kafka_topic_batchcnt{job=~\"$job\"}",
"expr": "tdg_kafka_topic_batchcnt{job=~\"$job\",quantile=\"0.99\"}",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{name}} ({{topic}}) — {{alias}} ({{type}}, {{connector_name}})",
Expand Down

0 comments on commit 130ef88

Please sign in to comment.