pack: support .packignore #1096
Open
+1,280
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
5 times, most recently
from
f7a3cdc to
3c54756
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
3c54756 to
6e08a11
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
6e08a11 to
f8132ea
Compare
dmyger
reviewed
Feb 11, 2025
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
3 times, most recently
from
263b010 to
3054d90
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
3054d90 to
5b191c3
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
5b191c3 to
19aca8b
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
2 times, most recently
from
cefb7aa to
d153b43
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
c6c2d85 to
f434832
Compare
cli/util/osfs.go
Outdated
Comment on lines
9
to
15
|
|
||
| func GetOsFS() fs.FS { |
There was a problem hiding this comment.
Please, add a comment about problem being solved of the function. It is not clear why it is required for a reader out of the context.
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
2 times, most recently
from
28cae6c to
ef9e1ec
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
ef9e1ec to
5db42c2
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
3 times, most recently
from
2a350e4 to
ac2a9c8
Compare
oleg-jukovec
approved these changes
Feb 20, 2025
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
2 times, most recently
from
31e1920 to
4585ec5
Compare
dmyger
reviewed
Feb 21, 2025
cli/util/util.go
Outdated
| @@ -1024,3 +1024,12 @@ func CollectWALFiles(paths []string) ([]string, error) { | |||
|
|
|||
| return collectedFiles, nil | |||
| } | |||
|
|
|||
| // Map is a generic slice mapper function. | |||
| func Map[T, V any](ts []T, fn func(T) V) []V { | |||
There was a problem hiding this comment.
Yes (see ignore_test.go)
There was a problem hiding this comment.
Let's put this code into the test code then.
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
4585ec5 to
3dcb739
Compare
patapenka-alexey
approved these changes
Feb 24, 2025
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
4 times, most recently
from
9fff4bb to
0621983
Compare
|
A few corrections have been applied:
|
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
0621983 to
44eb6ed
Compare
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
2 times, most recently
from
7b539ff to
e14d838
Compare
In some cases, there are files that may be useful, but should not be part of artifact. The ability to add files and directories to the .packignore file has been added, which allows you to ignore these files and directories when packing. Closes #812 @TarantoolBot document Title: `tt pack` support `.packignore` Use `.packignore` in the same way as `.gitignore` allows to exclude unnecessary files while preparing application package with `tt pack command.
elhimov
force-pushed
the
elhimov/gh-812-tt-pack-allow-to-ignore-paths
branch
from
e14d838 to
3aa4384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, there are files that may be useful, but should not be part of artifact. The ability to add files and directories to the .packignore file has been added, which allows you to ignore these files and directories when packing.
Closes #812