storage: fix schema log message #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentian
requested review from
Gerold103
and removed request for
Gerold103
Serpentian
force-pushed
the
fix-core-version
branch
2 times, most recently
from
2125660 to
bdf8601
Compare
Gerold103
requested changes
Jan 10, 2024
Serpentian
force-pushed
the
fix-core-version
branch
from
bdf8601 to
fc3108a
Compare
exports_deploy_funcs() used to log the core version as nil. The problem is the fact, that table.concat was used for core version string, so the complied exports always had nil instead of core_version. table.concat doesn't work with non-array tables, as they have no defined order. Let's explicitly define __tostring function for version and use it in order to log core version. Closes tarantool#465 NO_DOC=bugfix
Serpentian
force-pushed
the
fix-core-version
branch
from
fc3108a to
8980218
Compare
Gerold103
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage: fix schema log message
exports_deply_funcs() used to log the core version as nil. The problem
is the fact, that table.concat was used for core version string, so the
complied exports always had nil instead of core_version.
table.concat doesn't work with non-array tables, as they have no defined
order. Let's explicitly define __tostring function for version and use
it in order to log core version.
Closes #465
NO_DOC=bugfix