Only show one error toast at a time #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tarasglek wanted to only show the last error on screen to avoid confusion with lots of stacked error toasts.
This quick PR does exactly that by keeping track of any open error toast ids, and closing them whenever a new error toast is triggered.
Here's a quick demo of how it works.

It wasn't clear to me if this was exactly what we wanted, or hide any open toasts on submitting a completion, so I went with whatever I understood.
One problem I see with this approach is that some important error messages might be lost if multiple relevant error toasts are relevant at a time.
This fixes #667