input lag fix #708
Merged
input lag fix #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying chatcraft-org with
|
| Latest commit: |
2548100
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://904e2aa3.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://taras-input-lag.console-overthinker-dev.pages.dev |
|
Not super excited to duplicate this fix for mobile..would be nice to unify the logic and just keep rendering separate |
humphd
reviewed
Nov 3, 2024
| @@ -164,27 +161,25 @@ function DesktopPromptForm({ | |||
| switch (e.key) { | |||
| // Allow the user to cursor-up to repeat last prompt | |||
| case "ArrowUp": | |||
| if (!isDirty && previousMessage) { | |||
| if (isPromptEmpty && previousMessage && inputPromptRef.current) { | |||
There was a problem hiding this comment.
Could you get rid of the isPromptEmpty state completely and do:
if (inputPromptRef.current?.value === "" && previousMessage) {There was a problem hiding this comment.
here either would work, this is just more consistent cos it does trim in state
| @@ -422,7 +418,7 @@ function DesktopPromptForm({ | |||
| /> | |||
|
|
|||
| <Flex alignItems="center" gap={2}> | |||
| <KeyboardHint isVisible={!!prompt.length && !isLoading} /> | |||
| <KeyboardHint isVisible={!isPromptEmpty && !isLoading} /> | |||
There was a problem hiding this comment.
I'm not sure if doing inputPromptRef.current.value !== "" works here, but it might
There was a problem hiding this comment.
doesnt cos you need to trigger a react rerender
| if (settings.enterBehaviour === "newline") { | ||
| handleMetaEnter(e); | ||
| } else if (settings.enterBehaviour === "send") { | ||
| if (!e.shiftKey && prompt.length) { | ||
| if (!e.shiftKey && !isPromptEmpty) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopped keeping prompt in react. @humphd how's this change?