Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block sending chat when clicking Ask button #710

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

humphd
Copy link
Collaborator

@humphd humphd commented Nov 3, 2024

I've removed the extra logic that was blocking the chat from being submitted to the LLM when you click the Ask button. It's annoying how it just doesn't do anything when you click "Ask" without telling you what's wrong.

Copy link

cloudflare-workers-and-pages bot commented Nov 3, 2024

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c91eec
Status: ✅  Deploy successful!
Preview URL: https://8a93cd70.console-overthinker-dev.pages.dev
Branch Preview URL: https://humphd-simplify-ask-submit-l.console-overthinker-dev.pages.dev

View logs

@humphd humphd requested a review from tarasglek November 3, 2024 19:31
@tarasglek
Copy link
Owner

lovely when simplification of ux and code come together like this

@tarasglek tarasglek merged commit e29d6d0 into main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants