Avatar for Meta-Llama-3.1-405B-Instruct model fixed #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
requested changes
Nov 6, 2024
src/lib/ChatCraftModel.ts
Outdated
| @@ -43,7 +43,7 @@ export class ChatCraftModel { | |||
| return "/google-gemini-logo.png"; | |||
| } | |||
|
|
|||
| if (this.name.includes("llama")) { | |||
| if (this.name.toLowerCase().includes("llama")) { | |||
There was a problem hiding this comment.
This is a good fix, but let's do it everywhere in the function. At the top of logoUrl() can you do:
const vendor = this.vendor.toLowerCase();
const modelName = this.name.toLowerCase();Then change all the uses of this.name to use modelName
humphd
requested changes
Nov 6, 2024
src/lib/ChatCraftModel.ts
Outdated
| return "/microsoft-phi-logo.png"; // Microsoft's Phi model logo | ||
| } | ||
|
|
||
| if (vendor === "google") { | ||
| return "/google-gemini-logo.png"; | ||
| } | ||
|
|
||
| if (this.name.includes("llama")) { | ||
| if (modelName.toLowerCase().includes("llama")) { |
There was a problem hiding this comment.
modelName is already lowercase
There was a problem hiding this comment.
I am so sorry for making you check the code many times ...
All model names are checked in in a case-insensitive manner for Avatar
humphd
approved these changes
Nov 6, 2024
|
Make sure you do these changes on topic branches, not your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Fixes #704
The
logoUrl()function in theChatCraftModelclass checks the model’s name to determine the correct logo URL. However, some Llama model names contain uppercase letters, causing the function to fail to retrieve the correct logo for these models.This issue affected models like
sambanova/Meta-Llama-3.1-405B-Instructandsambanova/Meta-Llama-3.1-70B-Instruct, among others. This update ensures that model names are handled in a case-insensitive manner for modelsHow I tested
pnpm buildand ran it withpnpm preview --hostboth for Desktop version(macbook m4) and Mobile version(iPhone 15pro).Screenshot with Desktop Test
Meta-Llama-3.1-70B-Instruct
Meta-Llama-3.1-405B-Instruct
Screenshot with Mobile Test