it allows zoom-gesture when PreferencesModal is open #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghif
reviewed
Nov 17, 2024
There was a problem hiding this comment.
This fixes the bug!
You should also increase the textbox font size to at least 16px to prevent the automatic zoom on safari iOS.
https://css-tricks.com/16px-or-larger-text-prevents-ios-form-zoom/
font-size in input element modified to prevent auto-zoom-in in Safari
gitdevjin
force-pushed
the
zoom-issue
branch
from
cb17b7d to
d050038
Compare
|
@menghif Thank you always for your kind feedback, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #731
I implemented the second solution, enabling zoom-in functionality when the
PreferencesModalis open on both mobile and desktopHow I tested
I tested it on an iPhone 15 Pro and Google Chrome on desktop, and it now allows zoom-in, zoom-out, as well as scrolling when zoomed in
Test Screenshot
Zoomed in
Zoomed out