This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Introduce Github V4 Api For Chronological Tags #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remoz
reviewed
Mar 18, 2019
415DomSmith
reviewed
Mar 18, 2019
remoz
approved these changes
Mar 18, 2019
therynamo
added a commit
that referenced
this pull request
Mar 15, 2021
* Introduce Github V4 Api For Chronological Tags * Remove Consoles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a small bridge between the v3 and v4 github apis. What this gives us is the ability to retrieve
tagschronologically. This will resolve a bug for all users where they would not see tags that should be there, resulting in empty captain's logs.This not the final migration of the v4 api. That will come in a subsequent pull request and be a major version bump. The reason we did not include that here is that we needed a stop gap due to this schema not being included in the most recent version of the GHE api. Once this is added, all GHE users can feel free to upgrade and use the full v4 api. That version should offer some performance improvements.
Dependency Additions
toMatchInlineSnapshotRelated Issues
#16