-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
박스오피스 앱 [Step3] 이지, 희동 #60
Open
MyNB1
wants to merge
18
commits into
tasty-code:d_Hidong
Choose a base branch
from
MyNB1:step3
base: d_Hidong
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
294e8e9
chore: MovieInfoSubdetail 하위 DTO 이름 변경
yoruck2 c87cdeb
feat: HTTPMethod enum추가
yoruck2 da5e705
refactor: parseJSON -> decode movieData -> data
yoruck2 3bbaca9
..
yoruck2 15a4c46
feat: navigationController 추가
yoruck2 0e7d1a0
refactor: DailyBoxOfficeResultDTO -> DailyBoxOfficeDTO
yoruck2 f8a2d67
refactor: networkAPI -> APIURLBuilder
yoruck2 0236792
feat: Date.yesterday 추가
yoruck2 806962d
feat: dateFormmater 추가
yoruck2 16e56ba
chore: 자잘한 수정
yoruck2 c4f26d8
refactor: performRequest async 메서드로 수정
yoruck2 6aab401
feat: String.formatNumberString 추가
yoruck2 4fde876
feat: MovieListViewController하위 뷰 추가
yoruck2 808a567
feat: MovieListCollectionViewCell 구현
yoruck2 a295979
refactor: yesterday 메서드로 통합
yoruck2 51c6247
refactor: yesterday 메서드로 통합
yoruck2 4bb1ce7
chore: 자잘한 수정
yoruck2 73a23ea
refactor: dateFormatter에 TimeZone 추가
yoruck2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// | ||
// Date+.swift | ||
// BoxOffice | ||
// | ||
// Created by dopamint on 3/19/24. | ||
// | ||
|
||
import Foundation | ||
|
||
extension Date { | ||
static let yyyyMMdd = "yyyyMMdd" | ||
static let yyyyMMddHyphen = "yyyy-MM-dd" | ||
|
||
func yesterday(format: String) -> String { | ||
let dateFormatter = DateFormatter() | ||
dateFormatter.dateFormat = format | ||
dateFormatter.timeZone = TimeZone(abbreviation: "UTC") | ||
|
||
let today = Date() | ||
let timezone = TimeZone.autoupdatingCurrent | ||
let secondsFromGMT = timezone.secondsFromGMT(for: today) | ||
let localizedDate = today.addingTimeInterval(TimeInterval(secondsFromGMT)) | ||
let yesterday = Calendar(identifier: .gregorian).date(byAdding: .day, value: -1, to: localizedDate) | ||
guard let dateString = dateFormatter.string(for: yesterday) else { | ||
return "알 수 없는 날짜" | ||
} | ||
return dateString | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// | ||
// String+.swift | ||
// BoxOffice | ||
// | ||
// Created by dopamint on 3/19/24. | ||
// | ||
|
||
import Foundation | ||
|
||
extension String { | ||
func formatNumberString() -> String { | ||
let formatter = NumberFormatter() | ||
formatter.numberStyle = .decimal | ||
guard let number = Double(self), | ||
let result = formatter.string(from: NSNumber(value: number)) | ||
else { | ||
return "" | ||
} | ||
return result | ||
} | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다음과 같이 수정해 보았습니다!