UI/UX and backend changes in the plugin #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennyabrain
reviewed
Jan 16, 2025
|
|
||
| #### Changing the Scope of non-liveview routes | ||
| - As the route addresses were the same in both cases, the `scope` for the non-liveview routes was changed from `"/"` to `"/nolive"`. | ||
| - By default, on clicking the registration and login buttons on the homepage, everything will render the liveview templates. To access the similar route for the no-liveview templates prepend `/nolive` to the route. |
There was a problem hiding this comment.
A non-critical feedback. Since the server URLs are public, something like nolive seems odd. We'll see if we can replace this with something more proper later.
|
The sub-issue #651 has been resolved in this PR. Users can now use the replace slur and show metadata features without authentication. |
aatmanvaidya
approved these changes
Jan 20, 2025
|
@dennyabrain was able to pull and test this PR out locally
we can merge the PR now |
|
@aatmanvaidya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR. Currently, the following changes have been made:
This description will keep on updating as new changes are made.
CC: @aatmanvaidya