fix(windows): decoupling the effects of switching between fullscreen
and maximized
.
#1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned here
Detials
set_maximized(false)
will fire theSW_RESTORE
, and it disturbs the state of theborderless fullscreen
.To be precise, the window size that should have kept the full screen has been changed (to normal window size).
Solution
SetWindowLongW(... !WS_MAXIMIZE ...)
instead ofShowWindow(..., SW_RESTORE)
to set the maximized state off.set_fullscreen(false)
when the window is maximized or not.