-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add screenshot functionality #1258
base: dev
Are you sure you want to change the base?
Conversation
db90c84
to
fb8e6ab
Compare
I'm getting an
This is crashing on
Thanks for your work here! |
Hi! Yes, I pretty much gave up on the macOS implementation and in my own project currently have it disabled entirely. I believe I did have the "newer" version working at some point and lost it, or it might actually work right now but require granting the running application an Accessibility permission so it can capture properly - possibly both. Either way, the performance is also catastrophic using either method, which further contributed to me abandoning the work. I've since had some ideas about alternatives (grabbing the window handle and using something like |
Based on work in PR #226 - adds screenshot functionality to macOS, linux and Windows. Android is unsupported.
Compared to 226, this PR does not include the region selection functionality. This comment in the Webview2 repo indicates that it may now be possible to have parity across all three platforms in selecting regions, and so make it worthwhile to re-add.
This PR does not (yet) improve on the API presented in 226.