fix(android): BorrowError crash when loading assets on Android #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition on the Android asset loading where the custom asset loading function is checked by the Java side while Rust is still setting it up, leading to a `already mutably borrowed: BorrowError` panic in the withAssetLoader function. Looks like moving the function setup to happen before triggering the webview creation fixes it.
Package Changes Through 154d52aThere are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
this is a bit difficult to reproduce, but it looks like it's not crashing anymore. |
|
script i've used to verify it: basically reopening the app every 2 seconds to see if it loads properly |
|
user reported a different crash, I'll investigate further tomorrow |
|
looks like the reported crash is not related to this change (only happens in prod) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition on the Android asset loading where the custom asset loading function is checked by the Java side while Rust is still setting it up, leading to a
already mutably borrowed: BorrowErrorpanic in the withAssetLoader function.Using Mutex instead of RefCell is the safer approach. Performance impact shouldn't be relevant here, since it's only a small lookup overhead every IPC and asset loading call.
ref tauri-apps/tauri#12812