Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multimple monitors #12

Closed
wants to merge 2 commits into from
Closed

Conversation

mrowqa
Copy link

@mrowqa mrowqa commented Mar 4, 2018

Hi,

thanks for the tool. I thought about writing such a thing myself, but eventually I landed here. Here is some contribution of mine that adds support for multiple monitors.

Regards,
mrowqa

@mrowqa
Copy link
Author

mrowqa commented Mar 4, 2018

Solves #11.

@Ortega-Dan
Copy link

Hey @taviso , Looks like this contribution is nice. Please merge it into main. This project is great. And this pull request will make it better.

@taviso
Copy link
Owner

taviso commented Feb 23, 2019

Thanks! Sorry for the slow response, the patch does indeed look good.

I'm just thinking about how to make it optional, i.e. if I only want it on one monitor. I like that there are no configuration files or registry keys, so I think maybe it should be an #ifdef. hmmm..

@mrowqa
Copy link
Author

mrowqa commented Feb 23, 2019

if I only want it on one monitor

Assuming it's just an example, does anyone actually want such a behavior? As far as I remember, on gnome shell the corners work on all screens.

You can also try changing MAX_MONITORS to 1 and see how it behaves. Hopefully, it iterates over monitors in the same order.

@Ortega-Dan
Copy link

if I only want it on one monitor

Assuming it's just an example, does anyone actually want such a behavior? As far as I remember, on gnome shell the corners work on all screens.

You can also try changing MAX_MONITORS to 1 and see how it behaves. Hopefully, it iterates over monitors in the same order.

Yeap, it works on all screens on Gnome 3.

Ortega-Dan added a commit to Ortega-Dan/hotcorner that referenced this pull request Feb 23, 2019
@Ortega-Dan Ortega-Dan mentioned this pull request Apr 23, 2019
@gitguys
Copy link

gitguys commented Apr 19, 2020

Is there a pre-compiled binary available for download that works on all connected monitors?

@mrowqa
Copy link
Author

mrowqa commented Apr 20, 2020

@gitguys I decided not to provide any binaries since building it is quick and simple and I adjusted the constants & hotkey locally for my personal usage.

@Ortega-Dan
Copy link

Ortega-Dan commented May 9, 2020

@gitguys I actually have a precompiled .exe that I deploy to my windows machines ... I've had it there for more than one year ... (as you can see from the last commits in there)
You can check it out here .. withSuperEasyInstallInstructions

That was thanks to @mrowqa changes .. (his name is in my version of the README)

taviso added a commit that referenced this pull request Jun 22, 2020
@taviso taviso closed this Jun 22, 2020
TheQwerty added a commit to TheQwerty/hotcorner that referenced this pull request Oct 27, 2020
Fix taviso#21 and taviso#12 by adding links to variations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants