Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring profile errors when merging, message on empty profile #136

Merged
merged 8 commits into from
Sep 10, 2023

Conversation

Midnighter
Copy link
Contributor

Too late to add further testing right now.

@Midnighter Midnighter self-assigned this Sep 2, 2023
@Midnighter Midnighter requested a review from a team September 2, 2023 21:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023

Codecov Report

Patch coverage: 45.18% and project coverage change: +2.32% 🎉

Comparison is base (98713de) 85.87% compared to head (3715353) 88.19%.

❗ Current head 3715353 differs from pull request most recent head 9cde5a0. Consider uploading reports for the commit 9cde5a0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #136      +/-   ##
==========================================
+ Coverage   85.87%   88.19%   +2.32%     
==========================================
  Files         114      114              
  Lines        1791     1762      -29     
  Branches      325      303      -22     
==========================================
+ Hits         1538     1554      +16     
+ Misses        205      176      -29     
+ Partials       48       32      -16     
Files Changed Coverage Δ
...rc/taxpasta/infrastructure/application/__init__.py 100.00% <ø> (ø)
src/taxpasta/infrastructure/cli/merge.py 61.34% <28.57%> (+8.74%) ⬆️
src/taxpasta/infrastructure/cli/standardise.py 47.88% <35.29%> (+15.59%) ⬆️
src/taxpasta/application/add_tax_info_command.py 41.86% <41.86%> (ø)
...axpasta/application/sample_handling_application.py 76.31% <57.89%> (ø)
src/taxpasta/application/__init__.py 100.00% <100.00%> (ø)
...rc/taxpasta/domain/model/tidy_observation_table.py 100.00% <100.00%> (ø)
...rc/taxpasta/domain/model/wide_observation_table.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Midnighter Midnighter merged commit cb3a710 into dev Sep 10, 2023
@Midnighter Midnighter deleted the fix-empty-profile branch September 10, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ignoring profile errors when merging
3 participants