Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix #201

Merged
merged 1 commit into from
Jan 5, 2024
Merged

typo fix #201

merged 1 commit into from
Jan 5, 2024

Conversation

key2peace
Copy link
Contributor

@key2peace key2peace commented Jan 5, 2024

Error occured while testing:

Traceback (most recent call last):
  File "/home/outsider/doorbell/./i2c_doorbell.py", line 329, in <module>
    phone = VoIPPhone(phoneParms)
            ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/pyVoIP/VoIP/phone.py", line 60, in __init__
    and self.voip_phone_parameter.call_call
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'VoIPPhoneParameter' object has no attribute 'call_call'. Did you mean: 'call_class'?

Converted to Draft as I see more typo's appearing while testing this branch,

I also noticed while converting my code to use this branch a LOT changed and nothing really has been documented (the documentation page also does not really help as picking the development branch there also shows the old usage, so I am kinda figuring out how to set things up based on the code...)

@key2peace key2peace marked this pull request as draft January 5, 2024 11:19
Copy link
Owner

@tayler6000 tayler6000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge this change as is and open another PR for additional typos if you'd like

@key2peace key2peace marked this pull request as ready for review January 5, 2024 20:16
@tayler6000 tayler6000 merged commit 9cba94c into tayler6000:development Jan 5, 2024
3 checks passed
@tayler6000 tayler6000 mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants