Add asynchronous support #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I will take a look at this in the next couple days |
taylorhakes
reviewed
Feb 17, 2025
| @@ -10,12 +10,12 @@ | |||
| import zlib | |||
|
|
|||
|
|
|||
| redis_host = "redis-test-host" | |||
| redis_host = "localhost" | |||
There was a problem hiding this comment.
This will break the tests. It can't be localhost
taylorhakes
reviewed
Feb 17, 2025
| client = StrictRedis(host=redis_host, decode_responses=True) | ||
| client_no_decode = StrictRedis(host=redis_host) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session", autouse=True) | ||
| @pytest.fixture(scope="module", autouse=True) |
There was a problem hiding this comment.
Can you add async tests for AsyncRedis and adding a decorator to an async function?
taylorhakes
reviewed
Feb 17, 2025
| @@ -247,7 +356,25 @@ def invalidate(self, *args, **kwargs): | |||
| pipe.zrem(self.keys_key, key) | |||
| pipe.execute() | |||
|
|
|||
| async def async_invalidate(self, *args, **kwargs): | |||
There was a problem hiding this comment.
Let's add tests for all the new code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces asynchronous support to the python-redis-cache library, allowing for non-blocking I/O operations and improved performance in environments requiring async operations.
Motivation
With increasing adoption of async frameworks like FastAPI, this enhancement allows the library to be used more efficiently in such environments, reducing I/O blocking and improving performance for developers working with asynchronous applications. #41
Potential Impact
These changes should not affect existing users who use the synchronous methods, as they remain fully supported. Asynchronous users will benefit from faster I/O operations without major codebase changes.