Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whisper.cpp version to 1.5.4 #109

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

Andreybest
Copy link
Contributor

Title says it all.

Changed version of whisper-rs-sys to 0.8.1

Works for me in simple environment as before.

Fixes #103

@tazz4843
Copy link
Owner

tazz4843 commented Jan 7, 2024

Looks like whisper.cpp added a new function in these updates, this should be added: see ggerganov/whisper.cpp@d38af15...0b9af32#diff-46bc59b448d0e369ff4fbbc995a5c509db6caf1cee3a458f17482fae3086e457R318-R319

@Andreybest
Copy link
Contributor Author

Looks like whisper.cpp added a new function in these updates, this should be added: see ggerganov/[email protected]#diff-46bc59b448d0e369ff4fbbc995a5c509db6caf1cee3a458f17482fae3086e457R318-R319

My bad, haven't checked .h file changes. Added this function + bumped version of whisper-rs to 0.10.1
And I supposed that the bindings.rs file is being generated into src/ folder, but it's not.
So I've copied it from build folder. Not sure if it's correct approach, sorry - first time working with bindings.

@tazz4843
Copy link
Owner

tazz4843 commented Jan 8, 2024

If possible, can you run bindgen on a Linux system to minimize the change here? If not, no worries, just remove the bindings and I'll do so myself after merge.

@Andreybest
Copy link
Contributor Author

If possible, can you run bindgen on a Linux system to minimize the change here? If not, no worries, just remove the bindings and I'll do so myself after merge.

Done. Thx.

@tazz4843 tazz4843 merged commit 849f07c into tazz4843:master Jan 8, 2024
13 checks passed
@tazz4843
Copy link
Owner

tazz4843 commented Jan 8, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process exits when language detection is enabled
2 participants