Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos vulkan build script #177

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

newfla
Copy link
Contributor

@newfla newfla commented Sep 17, 2024

The PR fix the build on macos when targeting the vulkan backend.
Targeting the master branch will result in ld failing to link against vulkan. See GH action log.
With the updated build.rs build process is fine step check whisper-rs vulkan build.

@thewh1teagle
Copy link
Contributor

@newfla

Do you know if Vulkan works on both Intel/arm macOS? I tried to build whisper.cpp with VULKAN_SDK set to export VULKAN_SDK="/Users/user/VulkanSDK/1.3.290.0/macos" but it doesn't build and give me this errors

/Users/user/Documents/whisper.cpp/ggml/src/ggml-vulkan.cpp:1215:97: error: use of undeclared identifier 'matmul_f16_f32_len'; did you mean 'matmul_f16_fp32_len'?

@newfla
Copy link
Contributor Author

newfla commented Sep 22, 2024

@newfla

Do you know if Vulkan works on both Intel/arm macOS? I tried to build whisper.cpp with VULKAN_SDK set to export VULKAN_SDK="/Users/user/VulkanSDK/1.3.290.0/macos" but it doesn't build and give me this errors

/Users/user/Documents/whisper.cpp/ggml/src/ggml-vulkan.cpp:1215:97: error: use of undeclared identifier 'matmul_f16_f32_len'; did you mean 'matmul_f16_fp32_len'?

@thewh1teagle it crashses on my amd hackintosh :(

@tazz4843 tazz4843 merged commit d706878 into tazz4843:master Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants