fix: include ggml sources #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xd009642
reviewed
Nov 20, 2024
tazz4843
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
I do worry about future added code blowing up the size of the crates.io download (went from 20MB -> ~3MB after adding these includes originally, this PR bumps that from 4MB -> 8MB) but that's a problem for the future I figure. Looks good to me, sorry I took so long to respond here.
|
whisper-rs-sys 0.11.1 published, cargo should automatically resolve it as a new dep if you do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whisper-rs-sys published on crates.io is lacking of essential ggml src files and won't compile.
Should fix #187 #190