Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds safe bindings for set_new_segment_callback #97

Closed
wants to merge 7 commits into from

Conversation

WindowsCmd
Copy link

As the title implies. Introduces set_segment_callback_safe.

@garyhai
Copy link

garyhai commented Oct 30, 2023

                self.fp.new_segment_callback_user_data = closure as *mut c_void;
                self.fp.new_segment_callback = Some(trampoline::<SegmentCallbackFn>);
                self.segment_calllback_safe = None; 

It is bug here. Should be:

                self.segment_calllback_safe = Some(Box::new(closure));

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Apr 13, 2024

As the title implies. Introduces set_segment_callback_safe.

Thanks!
I already use it in the project vibe
and it works great as is (although I created new one lossy to ignore bad utf-8 errors)

Does it gonna be merged?

@tazz4843
Copy link
Owner

tazz4843 commented Jun 3, 2024

Superseded by #153

@tazz4843 tazz4843 closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants