Skip to content

Commit

Permalink
Build with ICU
Browse files Browse the repository at this point in the history
  • Loading branch information
tbossi committed Jul 12, 2021
1 parent b1dee67 commit 1976e0f
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 22 deletions.
16 changes: 7 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: linux_x86-64
path: '~/v8/v8/out.gn/x64.release/*.so'
path: '~/v8/v8/out.gn/x64.release/'

build_android_arm_v8:
name: Android (arm64-v8a)
Expand All @@ -50,7 +50,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: android_arm64-v8a
path: '~/v8/v8/out.gn/arm64.release/*.so'
path: '~/v8/v8/out.gn/arm64.release/'

build_android_arm_v7:
name: Android (armeabi-v7a)
Expand All @@ -65,7 +65,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: android_armeabi-v7a
path: '~/v8/v8/out.gn/arm.release/*.so'
path: '~/v8/v8/out.gn/arm.release/'

build_android_x86_64:
name: Android (x86-64)
Expand All @@ -80,7 +80,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: android_x86-64
path: '~/v8/v8/out.gn/x64.release/*.so'
path: '~/v8/v8/out.gn/x64.release/'

build_android_x86:
name: Android (x86)
Expand All @@ -95,7 +95,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: android_x86
path: '~/v8/v8/out.gn/ia32.release/*.so'
path: '~/v8/v8/out.gn/ia32.release/'

build_macos:
name: macOS
Expand All @@ -110,7 +110,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: macos
path: '~/v8/v8/out.gn/x64.release/*.dylib'
path: '~/v8/v8/out.gn/x64.release/'

build_windows:
name: Windows
Expand All @@ -126,9 +126,7 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: windows
path: |
v8/v8/out.gn/x64.release/*.dll
v8/v8/out.gn/x64.release/*.lib
path: 'v8/v8/out.gn/x64.release/'

headers_and_documentation:
name: Headers and Documentation
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-android-arm-v7.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ target_cpu = "arm"
v8_target_cpu = "arm"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 1
'
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-android-arm-v8.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ target_cpu = "arm64"
v8_target_cpu = "arm64"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 1
'
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-android-x86-64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ target_cpu = "x64"
v8_target_cpu = "x64"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 1
'
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-android-x86.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ target_cpu = "x86"
v8_target_cpu = "x86"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 1
'
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ python ./tools/dev/v8gen.py x64.release -vv -- '
target_os = "linux"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 0
'
Expand Down
3 changes: 1 addition & 2 deletions builders/v8-macos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ python ./tools/dev/v8gen.py x64.release -vv -- '
target_os = "mac"
is_component_build = true
use_custom_libcxx = false
v8_enable_i18n_support = false
v8_use_snapshot = false
v8_enable_i18n_support = true
v8_use_external_startup_data = false
symbol_level = 0
'
Expand Down
2 changes: 1 addition & 1 deletion builders/v8-windows.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ call git apply --ignore-whitespace --verbose %GITHUB_WORKSPACE%\builders\BUILD.g


echo =====[ Building V8 ]=====
call python .\tools\dev\v8gen.py x64.release -vv -- target_os="""win""" is_component_build=true use_custom_libcxx=false is_clang=true use_lld=false v8_enable_verify_heap=false v8_enable_i18n_support=false v8_use_snapshot=false v8_use_external_startup_data=false symbol_level=0
call python .\tools\dev\v8gen.py x64.release -vv -- target_os="""win""" is_component_build=true use_custom_libcxx=false is_clang=true use_lld=false v8_enable_verify_heap=false v8_enable_i18n_support=true v8_use_external_startup_data=false symbol_level=0

call ninja -C out.gn\x64.release -t clean
call ninja -C out.gn\x64.release v8

0 comments on commit 1976e0f

Please sign in to comment.