Editorial: fix linking and change spelling of iterator interfaces #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
force-pushed
the
GH-3455
branch
2 times, most recently
from
9bcc6fe
to
aedc649
Compare
bakkot
reviewed
Oct 22, 2024
bakkot
reviewed
Oct 22, 2024
| @@ -4041,7 +4041,7 @@ <h1>Well-Known Intrinsic Objects</h1> | |||
| <td> | |||
| </td> | |||
| <td> | |||
| The prototype of wrapped Iterator objects returned by Iterator.from (<emu-xref href="#sec-%wrapforvaliditeratorprototype%-object"></emu-xref>) | |||
| The prototype of wrapped iterator objects returned by Iterator.from (<emu-xref href="#sec-%wrapforvaliditeratorprototype%-object"></emu-xref>) | |||
There was a problem hiding this comment.
This use could remain capitalized as well, since the returned values do in fact inherit from Iterator.
There was a problem hiding this comment.
Elsewhere we use "Iterator instance objects" to refer to iterators in a way that also requires that they inherit from Iterator.
bakkot
reviewed
Oct 22, 2024
|
This also fixes #3426 |
michaelficarra
force-pushed
the
GH-3455
branch
from
6c13427
to
533b0ea
Compare
jmdyck
previously requested changes
Oct 22, 2024
There was a problem hiding this comment.
There are two remaining (non-<h1>) occurrences of "Iterator Objects" that you presumably want to change to "Iterator objects":
has properties that are inherited by all For-In Iterator Objects.has properties that are inherited by all Async-from-Sync Iterator Objects.
bakkot
approved these changes
Oct 23, 2024
michaelficarra
force-pushed
the
GH-3455
branch
from
17ee72e
to
e301f73
Compare
syg
approved these changes
Oct 30, 2024
michaelficarra
added
ready to merge
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Nov 7, 2024
It looks like PR tc39#3459 missed these changes to capitalization and use of "<em>".
kimjg1119
pushed a commit
to kimjg1119/ecma262
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3455. This adds a bunch of
<dfn>s and the auto-linking is sooo much better. Also makes a lot of progress getting rid of the remaining<i>s that are used as pseudo-<dfn>s.edit: Actually, this eliminates all of the remaining
<i>s! Nice!