Editorial: Put module concrete methods in their own emu-clauses #3541
+572
−554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Mar 7, 2025
nicolo-ribaudo
force-pushed
the
headings-concrete-module-record
branch
from
08601d2 to
2edadfe
Compare
syg
approved these changes
Mar 26, 2025
bakkot
approved these changes
Mar 26, 2025
bakkot
added
the
ready to merge
ljharb
force-pushed
the
headings-concrete-module-record
branch
from
2edadfe to
c828627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3538 / #3391 (comment). This is especially useful for Source Text Module Record, since it "inherits" some abstract methods from two different "super classes".
Review with whitespace changes disabled: https://github.com/tc39/ecma262/pull/3541/files?w=1