Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Clarify and simplify GetLocaleVariants and IsStructurallyValidLanguageTag #928

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Editorial: Clarify and simplify GetLocaleVariants and IsStructurallyValidLanguageTag #928

merged 1 commit into from
Nov 1, 2024

Conversation

gibson042
Copy link
Contributor

Replace complex substring descriptions with better use of subtag references and existing operations.

@gibson042
Editorial: Clarify and simplify GetLocaleVariants and IsStructurallyV…
d43264a 
…alidLanguageTag

Replace complex substring descriptions with better use of subtag
references and existing operations.
@ben-allen ben-allen added the editorial Involves an editorial fix label Sep 27, 2024
ben-allen
ben-allen approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ben-allen ben-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, especially the changes to locales-currencies-tz. The note in locale.html initially caused me more confusion than it relieved, but I genuinely cannot think of a better wording.

@ben-allen ben-allen merged commit d557e03 into tc39:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-allen ben-allen ben-allen approved these changes

Assignees
No one assigned
Labels
editorial Involves an editorial fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @ben-allen