Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 DO NOT MERGE: reviewing results of automatic linebreak fixes 🚨 #273

Closed
wants to merge 1 commit into from
Closed

🚨 DO NOT MERGE: reviewing results of automatic linebreak fixes 🚨 #273

wants to merge 1 commit into from

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Aug 25, 2023 

fixed 572 erroneous linebreaks in meetings/2023-07/july-13.md
fixed 508 erroneous linebreaks in meetings/2023-07/july-12.md
fixed 386 erroneous linebreaks in meetings/2023-07/july-11.md

👀

@ctcpip ctcpip requested a review from acutmore August 25, 2023 02:50
@ctcpip ctcpip changed the title 🚨 test linebreak fixer 🚨 DO NOT MERGE: reviewing results of automatic linebreak fixes 🚨 Aug 25, 2023
ctcpip
ctcpip commented Aug 25, 2023
View reviewed changes
meetings/2023-07/july-11.md
@@ -144,8 +142,7 @@ Summary: Ecma Secretariat presentation:

The slides were reviewed, and suggested to read the documents of interest as noted in the Annex.
Congratulations: Standards approved by GA 27 June and posted on website:
ECMA-262 14th edition – ECMAScript® 2023 Language Specification
ECMA-402 10th edition – ECMAScript® 2023 Internationalization API specification
ECMA-262 14th edition – ECMAScript® 2023 Language Specification ECMA-402 10th edition – ECMAScript® 2023 Internationalization API specification
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ECMA-262 14th edition – ECMAScript® 2023 Language Specification ECMA-402 10th edition – ECMAScript® 2023 Internationalization API specification
- ECMA-262 14th edition – ECMAScript® 2023 Language Specification
- ECMA-402 10th edition – ECMAScript® 2023 Internationalization API specification

ctcpip
ctcpip commented Aug 25, 2023
View reviewed changes
meetings/2023-07/july-11.md
@@ -546,8 +539,7 @@ Presenter: Chris de Almeida (CDA)
- https://www.ecma-international.org/task-groups/tc39-tg3/
- [slides](https://drive.google.com/file/d/1MPHGzy4aH_vRnduuuuUucP7xq_clcrK2/)

CDA: So TG3. Update and convenor confirmation hopefully. Next slide, please
So as we discussed at the last meeting, TG3 has not been meeting due to lack of chair.
CDA: So TG3. Update and convenor confirmation hopefully. Next slide, please So as we discussed at the last meeting, TG3 has not been meeting due to lack of chair.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CDA: So TG3. Update and convenor confirmation hopefully. Next slide, please So as we discussed at the last meeting, TG3 has not been meeting due to lack of chair.
CDA: So TG3. Update and convenor confirmation hopefully. Next slide, please. So as we discussed at the last meeting, TG3 has not been meeting due to lack of chair.

@ctcpip
Copy link
Member Author

ctcpip commented Aug 25, 2023

alright, this turned out well. the only things I noticed were the one place where a list needed formatting, and then there are various places where a period was missing, but there was a line break. no big deal

@ctcpip ctcpip mentioned this pull request Aug 25, 2023
Merged
@ctcpip ctcpip closed this Aug 30, 2023
@ctcpip ctcpip deleted the test-new-notes-fix branch August 30, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acutmore acutmore Awaiting requested review from acutmore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ctcpip