Update missing source phase to be a SyntaxError #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Sep 5, 2024
This was referenced Oct 17, 2024
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Nov 12, 2024
Throw a SyntaxError when no source can be imported. Refs: tc39/proposal-source-phase-imports#65 Bug: 42204365, 376084070 Change-Id: I622d5b2c9efcd05021c9bf03ecd3107f5ac37c83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5941079 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Chengzhong Wu <[email protected]> Cr-Commit-Position: refs/heads/main@{#97129}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #49.
I believe since this is normative in Stage 3 it would need to go through plenary.