Editorial: Improve alignment between ISO 8601 vs. other-calendar operations #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
added
enhancement
calendar
Codecov Report
@@ Coverage Diff @@
## main #2506 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 20 20
Lines 10923 10923
Branches 2031 2031
=======================================
Hits 10431 10431
Misses 430 430
Partials 62 62 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 task
justingrant
reviewed
Feb 18, 2023
justingrant
reviewed
Feb 18, 2023
justingrant
reviewed
Feb 18, 2023
justingrant
reviewed
Feb 18, 2023
Co-authored-by: Justin Grant <[email protected]>
ptomato
approved these changes
Feb 24, 2023
ptomato
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Looks like everyone's review comments have been addressed. I'd like to merge this so we can keep other things moving along.
As for the notes that will need revision in #2485, I'll plan to rebase that on top of this when I merge it, and just remove the notes for now; if you have a suggestion for how they should be replaced instead, let me know over on that PR when you review it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2500