Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill changes for calendar data consistency validation #2585

Closed
wants to merge 5 commits into from

Conversation

Aditi-1400
Copy link
Collaborator

This pull request adds the polyfill changes for #2500 and also adds a minor fix for Temporal.Calendar.prototype.fields.

gibson042 and others added 4 commits May 1, 2023 18:11
"era" and "eraYear" are still checked in alphabetical order along with other fields
when the calendar specifies their relevance,
but ensuring both-or-neither and consistency between the pair and "year"
is no longer part of the operation (although it remains part of CalendarResolveFields
along with similar checks for "month" and "monthCode").

Fixes tc39#2465
@Aditi-1400
Copy link
Collaborator Author

Test updates: tc39/test262#3835

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could absorb this commit into #2500?

@Aditi-1400
Copy link
Collaborator Author

Closing this, these commits have been absorbed into #2500

@Aditi-1400 Aditi-1400 closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants