Editorial: Structured headers, AO for formatting UTC offset with nanoseconds #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces structured headers with return types for several PlainTime abstract operations. This will make it easier to see what types are changing when we introduce normalized time duration records.
Introduces structured headers with return types for several PlainDateTime abstract operations. This will make it easier to see what types are changing when we introduce normalized time duration records.
Recently the code for formatting UTC offsets with nanosecond precision was inlined into GetOffsetStringFor because that was the only place it was used. However, we need to use it in more than one place after the user code audit of #2519 because we'll be pre-calculating the UTC offset in cases where it's calculated more than once. Specifically, in ZonedDateTime.p.getISOFields(), so change that to use the new FormatUTCOffsetNanoseconds operation.
Codecov Report
@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
- Coverage 96.06% 96.06% -0.01%
==========================================
Files 20 20
Lines 11554 11553 -1
Branches 2195 2195
==========================================
- Hits 11099 11098 -1
Misses 391 391
Partials 64 64
|
justingrant
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
we just inlined FormatTimeZoneOffsetString into GetOffsetStringFor, but due to rebasing #2519 I'm having to un-inline it
Haha, easy come, easy go! Looks good.
Ms2ger
approved these changes
Aug 10, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 7, 2023
…d. r=mgaudet Implement changes from <tc39/proposal-temporal#2644>. Differential Revision: https://phabricator.services.mozilla.com/D189773
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 7, 2023
…d. r=mgaudet Implement changes from <tc39/proposal-temporal#2644>. Differential Revision: https://phabricator.services.mozilla.com/D189773
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 8, 2023
…d. r=mgaudet Implement changes from <tc39/proposal-temporal#2644>. Differential Revision: https://phabricator.services.mozilla.com/D189773 UltraBlame original commit: 3a76318008a0748a36cdf95fad86b3f16c675963
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 8, 2023
…d. r=mgaudet Implement changes from <tc39/proposal-temporal#2644>. Differential Revision: https://phabricator.services.mozilla.com/D189773 UltraBlame original commit: 3a76318008a0748a36cdf95fad86b3f16c675963
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 8, 2023
…d. r=mgaudet Implement changes from <tc39/proposal-temporal#2644>. Differential Revision: https://phabricator.services.mozilla.com/D189773 UltraBlame original commit: 3a76318008a0748a36cdf95fad86b3f16c675963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we just inlined FormatTimeZoneOffsetString into GetOffsetStringFor, but due to rebasing #2519 I'm having to un-inline it — it'll be used in more than one place when we pre-calculate the UTC offset nanoseconds in cases where it was calculated twice.
Also includes some commits adding more structured headers that I had queued up but never submitted.