Various fixes in the reference code #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
+ Coverage 96.05% 96.07% +0.02%
==========================================
Files 20 20
Lines 11604 11676 +72
Branches 2196 2203 +7
==========================================
+ Hits 11146 11218 +72
Misses 394 394
Partials 64 64
|
gibson042
approved these changes
Aug 19, 2023
This was left over from some refactoring.
The ZonedDateTime code path in ToTemporalDate was missing a return statement. Falling through to the PlainDateTime code path still gave the right answer, but options.overflow would be accessed an extra time. The spec is already correct here, so this makes the reference code more compliant.
In order to be able to properly test the normative change of not observably iterating an Array in CalendarFields, we have to eliminate a few more places in the reference code where, contrary to the spec, array iteration was observable.
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small compliance issues in the reference code, that I came across while doing other things. Also removes unnecessary code from the parser tests.